Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path prefix handling in S3-to-S3 copy #396

Merged
merged 14 commits into from
Jun 10, 2024
Merged

Fix path prefix handling in S3-to-S3 copy #396

merged 14 commits into from
Jun 10, 2024

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Jun 10, 2024

Fix #391 and add a test case

@at-wat at-wat self-assigned this Jun 10, 2024
@at-wat at-wat changed the title Add S3ToS3 test case Fix S3ToS3 Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (4db55d2) to head (2ab75ef).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   81.15%   81.25%   +0.09%     
==========================================
  Files           5        5              
  Lines         414      416       +2     
==========================================
+ Hits          336      338       +2     
  Misses         47       47              
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-wat at-wat changed the title Fix S3ToS3 Fix path prefix handling in S3-to-S3 copy Jun 10, 2024
@at-wat at-wat mentioned this pull request Jun 10, 2024
@at-wat at-wat requested a review from a team June 10, 2024 06:54
Copy link
Contributor

@kamatama41 kamatama41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@at-wat at-wat merged commit 21908de into master Jun 10, 2024
7 checks passed
@at-wat at-wat deleted the fix-s3-to-s3 branch June 10, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants